file chooser: Don't switch too eagerly to search mode
authorMatthias Clasen <mclasen@redhat.com>
Wed, 28 Jan 2015 22:01:30 +0000 (17:01 -0500)
committerMatthias Clasen <mclasen@redhat.com>
Wed, 28 Jan 2015 22:01:30 +0000 (17:01 -0500)
If the search entry doesn't consume the key event, don't
change to search mode. Otherwise, we interfere e.g. with
Ctrl and Shift keys for selection.

https://bugzilla.gnome.org/show_bug.cgi?id=743660

gtk/gtkfilechooserwidget.c

index bc9224ef4728db572b83764c9c8243f1fba28f90..f192ceb5770e9fcd7fbec0690591c025573ea614 100644 (file)
@@ -1246,11 +1246,12 @@ gtk_file_chooser_widget_key_press_event (GtkWidget   *widget,
   GtkFileChooserWidget *impl = (GtkFileChooserWidget *) widget;
   GtkFileChooserWidgetPrivate *priv = impl->priv;
 
-  if (priv->operation_mode != OPERATION_MODE_SEARCH)
-    operation_mode_set (impl, OPERATION_MODE_SEARCH);
-
   if (gtk_search_entry_handle_event (GTK_SEARCH_ENTRY (priv->search_entry), (GdkEvent *)event))
-    return TRUE;
+    {
+      if (priv->operation_mode != OPERATION_MODE_SEARCH)
+        operation_mode_set (impl, OPERATION_MODE_SEARCH);
+      return TRUE;
+    }
 
   return FALSE;
 }